Fixed threaded deadlock #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added code to release the GIL on NonlinearOptimizer optimize(), and MarginalCovarianceSolve initialize(). - This is needed to stop a deadlock which happens when multiple threads are enabled and they all try to aquire the GIL.
|
@Edwinem thanks a lot for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #8
The problem was that when multithreading is enabled a deadlock occurs, due to multiple threads trying to acquire the GIL which is held by the main thread. By adding py::call_guardpy::gil_scoped_release() to the optimize and initialize functions it ensures that the main thread releases the GIL.
This in general should be done for any long running C++ code.