-
-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to disable amazon's DRM #2849
Open
KonstantinosKoulaxizis
wants to merge
6
commits into
dooboolab-community:main
Choose a base branch
from
KonstantinosKoulaxizis:feat/ability-to-disable-amazon-drm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ability to disable amazon's DRM #2849
KonstantinosKoulaxizis
wants to merge
6
commits into
dooboolab-community:main
from
KonstantinosKoulaxizis:feat/ability-to-disable-amazon-drm
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonstantinosKoulaxizis
added
🤖 android
Related to android
🎯 feature
New feature
ⓐ amazon
labels
Sep 19, 2024
hyochan
requested changes
Sep 21, 2024
@@ -19,7 +19,8 @@ android { | |||
targetSdkVersion rootProject.ext.targetSdkVersion | |||
versionCode 34 | |||
versionName "1.16.2" | |||
buildConfigField "boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled().toString()`; | |||
buildConfigField "boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled().toString() | |||
buildConfigField "boolean", "ENABLE_AMAZON_DRM", getExtOrDefault("enableAmazonDrm")`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we make this look more like a boolean? Something like isAmazonDrmEnabled
would be great.
Additionally, providing documentation related to this feature would be great |
KonstantinosKoulaxizis
added
the
📖 documentation
Improvements or additions to documentation
label
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ⓐ amazon
🤖 android
Related to android
📖 documentation
Improvements or additions to documentation
🎯 feature
New feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, users want to manage the DRM with their own solution and not use Amazon's DRM. In the past, this was possible by unchecking the DRM option from Amazon's Developer console, but now you can only do it from their SDK.
The
react-native-iap
module by default will enable Amazon's DRM, but if a user doesn't want to leverage it, there is no option to disable it.With this PR a user can easily disable it by adding
isAmazonDrmEnabled=false
to their gradle.properties file.The default will be
true