valueBigInt ToFloat throw TypeError

dop251 · Aug 22, 2024 · e9606b3 · e9606b3
1 parent 5d79cc7
commit e9606b3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/builtin_bigint.go b/builtin_bigint.go
@@ -15,7 +15,8 @@ import (
 type valueBigInt big.Int
 
 func (v *valueBigInt) ToInteger() int64 {
-	panic(typeError("Cannot convert a BigInt value to a number"))
+	v.ToNumber()
+	return 0
 }
 
 func (v *valueBigInt) toString() String {
@@ -35,8 +36,8 @@ func (v *valueBigInt) String() string {
 }
 
 func (v *valueBigInt) ToFloat() float64 {
-	f, _ := new(big.Float).SetInt((*big.Int)(v)).Float64()
-	return f
+	v.ToNumber()
+	return 0
 }
 
 func (v *valueBigInt) ToNumber() Value {

diff --git a/vm.go b/vm.go
@@ -4441,6 +4441,9 @@ func cmp(px, py Value) Value {
 		}
 	}
 
+	px = toNumeric(px)
+	py = toNumeric(py)
+
 	switch nx := px.(type) {
 	case valueInt:
 		switch ny := py.(type) {