Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented BigInt #597

Merged
merged 17 commits into from
Aug 22, 2024
Merged

Implemented BigInt #597

merged 17 commits into from
Aug 22, 2024

Conversation

shiroyk
Copy link
Contributor

@shiroyk shiroyk commented Aug 18, 2024

Implemented BigInt, BigInt64Array, BigUint64Array

@dop251
Copy link
Owner

dop251 commented Aug 20, 2024

Thank you so much for submitting this! I'm going to try to review asap,

dop251
dop251 reviewed Aug 21, 2024
View reviewed changes
Copy link
Owner

@dop251 dop251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks once again for submitting this. It took a lot of work and I really appreciate it. Please check the comments. I haven't reviewed everything, but definitely most of it.

builtin_bigint.go Outdated Show resolved Hide resolved
builtin_bigint.go Outdated Show resolved Hide resolved
runtime.go Outdated Show resolved Hide resolved
compiler_expr.go Outdated Show resolved Hide resolved
typedarrays.go Outdated Show resolved Hide resolved
typedarrays.go Outdated Show resolved Hide resolved
builtin_object.go Outdated Show resolved Hide resolved
builtin_bigint.go Outdated Show resolved Hide resolved
@dop251 dop251 merged commit fa6d1ed into dop251:master Aug 22, 2024
4 checks passed
@heikkilamarko heikkilamarko mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dop251 dop251 dop251 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shiroyk @dop251