Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to QuickJS to reimplement the date parser to support more formats.
Differences from QuickJS implementation for compatibility with the original parser of goja:
ZZZ
.Some differences from the original parser of goja:
(These behaviors are consistent with Node.js v22. I haven't checked the source code of V8, I just modified some test cases in
TestDateParse
to test in Node.js to guess its behavior, after all, it's not in the ECMAScript specification.)Overall, this new parser is more relaxed and supports more formats (not limited to those added in the test), but does less validity checks than the one in the Go standard library. Let me know if you don't want to miss some validity checks.