P1444 fix #51
Open
P1444 fix #51
+1
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2023DEC Prerelease to Main
Whitespace/comment changes
Moved files to /src/ folder
deselect user config options
Prerelease to main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{ maxAllowedVspoof = actualPackVoltage - xx; } to eliminate p1444 with some 48S installs
At 15% SOC (Vp=165), maxAllowedVspoof = actualPackVoltage - 14; resulted in P1444 to be triggered under full assist.
maxAllowedVspoof = actualPackVoltage - 15; gave P code under sustained max assist.
Testing with -16v gave intermittent P code at 60% SOC (Vp=178)
Testing with -17v gave very intermittent P code at 75% SOC
Therefore minimum recommended value is -18V
not evaluated on 60S voltage range to double check the required min offset.