Cold Boot Proof of Concept #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtalim
reviewed
Jul 28, 2024
Comment on lines
+49
to
+50
| //you don't need to change any settings below this line (but you can if you know what you're doing): | ||
| //__________________________________________________________________________________________________ |
There was a problem hiding this comment.
Will the VOLTAGE_SPOOFING_ config be unnecessary moving forward?
| @@ -99,3 +103,28 @@ uint8_t key_getSampledState(void) | |||
| } | |||
|
|
|||
| ///////////////////////////////////////////////////////////////////////////////////////// | |||
|
|
|||
| void keyOn_coldBootTasks(void) | |||
There was a problem hiding this comment.
Suggestion:
This sequence might be better placed in firmwareLiBCM.ino itself--similar to how setup() and loop() define their respective sequences.
From an "object" perspective, a key says whether it's on, off, and if it has changed; but it shouldn't perform the system consequences of those states.
This also applies to key_handleKeyEvent_off(), key_handleKeyEvent_on(), and void key_stateChangeHandler().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.