Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniform gutters on the quick check page #607

Merged
merged 3 commits into from
May 9, 2024
Merged

Uniform gutters on the quick check page #607

merged 3 commits into from
May 9, 2024

Conversation

steve-fenton-octopus
Copy link
Contributor

@steve-fenton-octopus steve-fenton-octopus commented May 9, 2024 •
edited
Loading

Brings equal gutters on smaller devices.

Hopefully improves things for #534

Before

Text meets edge, and overflows on very small devices

After

Even gutters

@davidstanke
Copy link
Collaborator

/gcbrun

@dora-machine-user
Copy link
Collaborator

Cloud Build time: Thu May 9 18:46:44 UTC 2024
Preview this PR [with drafts on] at https://doradotdev-staging--pr607-drafts-on-bmg3mcmp.web.app
Preview this PR [with drafts off] at https://doradotdev-staging--pr607-drafts-off-7gt7594a.web.app

@davidstanke davidstanke self-requested a review May 9, 2024 20:09
davidstanke
davidstanke approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@davidstanke davidstanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful -- and TIL padding-inline! Thank you Steve!!!

@davidstanke davidstanke merged commit 8a3e94a into dora-team:main May 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidstanke davidstanke davidstanke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steve-fenton-octopus @davidstanke @dora-machine-user