Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing MacPro7,1 Memory Errors re-write #70

Open
wants to merge 110 commits into
base: master
Choose a base branch
from

Conversation

RTHPJM
Copy link

@RTHPJM RTHPJM commented Jun 4, 2021

I have re-written the Post Install - Fixing MacPro7,1 Memory Errors section.
I have added more information gathered from the community (credit forum.amd-osx.com member iGPU, thread entitled Memory Installation Fix for MacPro7,1 SMBIOS)
I have verified the steps and rewritten the guide appropriately.
The guide felt too large for a single page, therefore I have broken it up into four pages:
memory.md
memory-gathering-data.md
memory-presenting-four-dimms.md
memory-presenting-other-multiples.md

There are additional files in the extra-files folder, and additional images in the images folder (appropriate sub-folders)

I hope you will be able to merge this radical change into your excellent document set...
You might need to amend some of the links, and maybe look at (or re-work) the next/previous page links at the bottom of each page...

Regards
Paul

Copy link
Author

@RTHPJM RTHPJM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khronokernel can I respectfully ask you to review pull request #70

@RTHPJM
Copy link
Author

RTHPJM commented Jun 11, 2021

Oh I forked the master branch and worked on that. In hind sight I should have branched my local fork then committed back. Learning as I go. I’ll have to fix the lint and spelling issues in files changed by others. I’ll grind through but I’m a bit nervous about adding dictionary items where necessary for other people’s changes (I won’t be sure if it is a genuine spelling mistake or a missing dictionary item. I’ll do my best…)

@RTHPJM
Copy link
Author

RTHPJM commented Jun 12, 2021

Lint and spell checks are now okay. Build fails due to username/password on push.

@RTHPJM RTHPJM marked this pull request as draft July 11, 2021 06:58
@RTHPJM RTHPJM marked this pull request as ready for review July 11, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant