Skip to content

Commit

Permalink
feat(editor-content): fix error with block editor #2999 (#30046)
Browse files Browse the repository at this point in the history
### Proposed Changes
* Fix track by function

### Checklist
- [x] Tests
- [x] Translations
- [x] Security Implications Contemplated (add notes if applicable)

### Screenshots
Original             |  Updated
:-------------------------:|:-------------------------:
![Screenshot 2024-09-17 at 5 44
32 PM](https://github.com/user-attachments/assets/10d27134-8c62-44db-bbdc-57c1e522dbda)
| ![Screenshot 2024-09-17 at 4 56
12 PM](https://github.com/user-attachments/assets/bd058e06-7ffd-49f1-afaa-7cd6cd9edecb)

---------

Co-authored-by: Arcadio Quintero <[email protected]>
  • Loading branch information
nicobytes and oidacra authored Sep 19, 2024
1 parent 5b70657 commit ea7843a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export class SuggestionsListItemComponent implements FocusableOption, OnInit {
}

ngOnInit() {
this.icon = this.icon = typeof this.url === 'string' && !(this.url.split('/').length > 1);
this.icon = typeof this.url === 'string' && !(this.url.split('/').length > 1);
}

getLabel(): string {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<h3>{{ title }}</h3>
}
<dot-suggestion-list #list>
@for (item of items; track $index) {
@for (item of items; track item) {
@if (item.id !== 'divider') {
<dot-suggestions-list-item
[command]="item.command"
Expand All @@ -16,9 +16,6 @@ <h3>{{ title }}</h3>
} @else {
<div class="divider"></div>
}
<ng-template #divider>
<div class="divider"></div>
</ng-template>
}
</dot-suggestion-list>
</div>
Expand Down

0 comments on commit ea7843a

Please sign in to comment.