-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : [typescript-react-apollo] support useSuspenseQuery #392
Conversation
🦋 Changeset detectedLatest commit: 38d320a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@saihaj |
sorry. If I understand correctly, is it correct that the test failure of github action is resolved when the test code changes in my PR are merged? I'm not sure what part I need to fix separately. This is my first contribution, so please understand my lack of experience. 😭 |
hey @Hal-ang can you please run for the failing tests you need to update all the snapshots I think |
Thanks! I pushed the new updated snapshot and prettier code |
HI, @saihaj :D |
@Hal-ang looks like tests are still failing. Are they passing for you locally? |
actually I reverted things and CI on |
Oh! Sorry for the late confirmation. thanks I tried to syncing a fork branch and checked test on my local :D |
hey @Hal-ang can you run |
e9db367
to
290f32a
Compare
thank you I tried running that script and running 'yarn run test' from root. After that, I also confirmed that it was passed. However, I am worried because there is an import error in the created folder. 🥲 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work @Hal-ang!
Can we please add to the release notes that this requires |
isn't this a breaking change since it now requires apollo >= 3.8 and we can't opt out of suspense generation stuff? |
Description
Implemented useSuspenseQuery, which was added in apollo 3.8.0 version.
Related #388
Type of change
Please delete options that are not relevant.
expected)
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration
yarn run test
after update snapshot fileTest Environment:
@graphql-codegen/[email protected]
:Checklist:
CONTRIBUTING doc and the
style guidelines of this project