Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make offlineExchange import respect useTypeImports #446

Closed
wants to merge 4 commits into from

Conversation

HalfdanJ
Copy link

@HalfdanJ HalfdanJ commented Oct 7, 2023

Description

Change import of offlineExchange from @urql/exchange-graphcache to respect config.useTypeImports since only types are used in the generated code.

Related # (issue)

#445

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

How Has This Been Tested?

Have tested that typescript configured with importsNotUsedAsValues = error no longer throws errors during tsc after the change has been made.

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...

@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2023

⚠️ No Changeset found

Latest commit: 7493c0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@HalfdanJ
Copy link
Author

Resolved the two failing tests

@saihaj
Copy link
Collaborator

saihaj commented Feb 2, 2024

hey @HalfdanJ can you please sync the branch with main and also run yarn changeset and explain the change so we can have it part of release notes. Read about changeset here

@saihaj saihaj added the waiting-for-answer Waiting for answer from author label Feb 2, 2024
@HalfdanJ
Copy link
Author

HalfdanJ commented Feb 6, 2024

I think this got resolved in this pr: #476. After i updated to latest version of the lib i was able remove my patch I had in place.

@HalfdanJ HalfdanJ closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-answer Waiting for answer from author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants