fix: timeout killing working connection #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for PR! |
This was
linked to
issues
Jul 11, 2024
4 tasks
|
Question: See this fix is merged to master. Any ETA for it to be available on npm? Thanks for all the good work! :) |
akabane-noex
pushed a commit
to akabane-noex/react-native-ble-plx
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a BleManager.connectToDevice with a timeout specified makes the timeout fire event though the connection is established just fine. Reason is that the timeout on Android side is applied to every emitted item when it has to be applied only to the first one. This PR fixes that. 😃