Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Swarm Config Api #387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Swarm Config Api #387

wants to merge 1 commit into from

Conversation

ty851123
Copy link

@ty851123 ty851123 commented May 2, 2019

@msftclas
Copy link

msftclas commented May 2, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@dgvives dgvives mentioned this pull request Jan 4, 2021
Closed
@dazinator
Copy link

This would be very useful to me, would be great if it could be merged.

@ACoderLife
Copy link
Contributor

@galvesribeiro Any chance this could be merged?
Is there something else needed?

@galvesribeiro
Copy link
Member

Unfortunately we can't get PRs that changes the .Generated.cs files. Those are meant to be generated by the Go generator for now, unfortunately.

Also, there are conflicts on it.

So I would suggest to update the model files instead and rebase the PR on the main branch so we can review.

Thanks!

@ACoderLife ACoderLife mentioned this pull request Sep 19, 2022
Merged
@dazinator
Copy link

Should this be closed in favour of #589 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ty851123 @msftclas @dazinator @ACoderLife @galvesribeiro @dgvives