Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default value of SslProtocol to SslProtocols.None. #2106

Merged
merged 2 commits into from
Dec 1, 2024
+5 −1
Merged

Set the default value of SslProtocol to SslProtocols.None. #2106

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72a237d
Set the default value of SslProtocol to SslProtocols.None.
xljiulang Nov 18, 2024
8b6e0c1
Add summary of SslProtocol.
xljiulang Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/MQTTnet.Server/Options/MqttServerTlsTcpEndpointOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public MqttServerTlsTcpEndpointOptions()

public bool CheckCertificateRevocation { get; set; }

public SslProtocols SslProtocol { get; set; } = SslProtocols.Tls12;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a summary comment including a reference to the MSDN so that users will understand the reason for "None" which looks like that SSL is not used at all.

public SslProtocols SslProtocol { get; set; } = SslProtocols.None;

public System.Net.Security.CipherSuitesPolicy CipherSuitesPolicy { get; set; }
}
Expand Down
Loading