Corrected Cancellation Source for KeepAlive Messages #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkr1011
reviewed
Dec 25, 2024
| { | ||
| timeoutCancellationTokenSource.CancelAfter(Options.Timeout); | ||
| await PingAsync(timeoutCancellationTokenSource.Token).ConfigureAwait(false); | ||
| keepAliveCancellationTokenSource.CancelAfter(keepAlivePeriod); |
There was a problem hiding this comment.
With this change the cancellation will happen earlier according to the keep alive period (15 seconds). Which is by default way smaller than the generic communication timeout (100 seconds).
But we already reached timeWithoutPacketSent > keepAlivePeriod so that wait an additional of 15 seconds (so 30 in total).
Isn't it a better way to wait for keepAlivePeriod / 2 to match the calculation at the server instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that the issue found in #2108 likely comes due to the fact that the wrong duration is used for checking the keep alive interval.
In this test setup i connect to a public broker and use the approach described in #2108 to see if it is triggered within time.
https://github.com/Erw1nT/MqttKeepAlive/blob/master/Program.cs
Only when this line is added, the connection-changed/disconnected event is fired in time.