Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] make it clear that Android target is needed for tests. #1857

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atsushieno
Copy link
Contributor

No description provided.

@atsushieno atsushieno requested a review from jonpryor as a code owner June 20, 2018 04:03
@jonpryor
Copy link
Member

The somewhat confusing thing is that while, yes, an Android emulator or device is required, make run-all-tests will attempt to create and launch an Android emulator if no device is attached:

https://github.com/xamarin/xamarin-android/blob/7c8b6e4ce93b2395f71ff7762afe7aadc416d3f3/build-tools/scripts/TestApks.targets#L21-L50

you need a running Android emulator or a connected Android device

This implies that the the Android target must already exist before running make run-all-tests, which shouldn't be the case.

In short, I'm not sure if this is a net improvement in clarity.

@atsushieno
Copy link
Contributor Author

make run-all-tests will attempt to create and launch an Android emulator if no device is attached

which never happened. It seems bogus then.

@atsushieno
Copy link
Contributor Author

atsushieno commented Jun 20, 2018

A funny thing happened: make run-apk-tests never launches such an emulator but msbuild /p:Configuration=Debug /v:diag /binaryLogger:"/sources/xamarin-android//bin/BuildDebug/msbuild-date +%s-run-apk-tests.binlog" build-tools/scripts/RunTests.targets /t:RunApkTests does.

Maybe some escaping issue in the shell? (unless /v change matters)

@atsushieno atsushieno force-pushed the fix-instruction-docs branch from d55861a to 368bfd8 Compare June 21, 2018 01:27
@atsushieno
Copy link
Contributor Author

Execution observation was not very strict - BOTH resulted in failure of emulator launches, which was exactly caused by this problem #1858 . The script seems to automatically create an emulator that is not compatible with platform-tools depending on the setup.

I have rewritten the part, still not to surprise contributors by installing random-looking apps or creating random emulator.

Base automatically changed from master to main March 5, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants