[build] Build with Microsoft OpenJDK 21.0.5 #9683
Open
+35
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pjcollins
requested review from
jpobst,
dellis1972,
jonathanpeppers and
Copilot
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (3)
- build-tools/xaprepare/xaprepare/Steps/Step_InstallAdoptOpenJDK.cs: Evaluated as low risk
- build-tools/automation/yaml-templates/variables.yaml: Evaluated as low risk
- build-tools/xaprepare/xaprepare/Steps/Step_GenerateFiles.cs: Evaluated as low risk
dellis1972
approved these changes
Jan 15, 2025
|
For those of us out of the loop, can you elaborate on what this means for our customers and our CI?
Once committed, anything that is new for .NET 10 should be documented here: #9571. |
|
jpobst
approved these changes
Jan 15, 2025
jonathanpeppers
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #9651
Context: 14a6bfb
Updates the macOS, Windows, and Linux build stages to install and build with Microsoft OpenJDK 21.0.5.
The nightly test jobs have also been updated to use JDK 21, while all other test jobs should continue to use JDK 17.
As of 14a6bfb, main/.NET 10 supports both JDK 17 and 21.
The default version that VS and the
InstallAndroidDependenciestarget will install is JDK 17, though we may want to upgrade this to 21 as we move further into the .NET 10 cycle.As of this PR, all explicit test stages that run against regular PR/CI will continue to use JDK 17. The build jobs, Windows smoke tests, and nightly test jobs will build and test against JDK 21. JDK 11 support was technically removed in df68c20, though I believe customers can add
<MinimumSupportedJavaVersion>11.0</MinimumSupportedJavaVersion>to their project files to use it. Some test coverage for this exists in ValidateJavaVersionTests, but this scenario is not tested end to end.