[illink] refactor code sharing between ILLink and MSBuild tasks #9688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have a few trimmer steps that run under both ILLink and the `<LinkAssembliesNoShrink/>` MSBuild task: * `AddKeepAlivesStep` * `FixAbstractMethodsStep` * `FixLegacyResourceDesignerStep` We want to move various parts of the build to become new trimmer steps like above. Previously, we also had to share these steps with the Xamarin.Android linker pipeline, but that's no longer the case. We can now cleanup how these trimmer steps are shared between ILLink and MSBuild, reducing the need for `#if ILLINK` in many places. I also removed various Mono linker source code that is unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have a few trimmer steps that run under both ILLink and the
<LinkAssembliesNoShrink/>MSBuild task:AddKeepAlivesStepFixAbstractMethodsStepFixLegacyResourceDesignerStepWe want to move various parts of the build to become new trimmer steps like above.
Previously, we also had to share these steps with the Xamarin.Android linker pipeline, but that's no longer the case. We can now cleanup how these trimmer steps are shared between ILLink and MSBuild, reducing the need for
#if ILLINKin many places.I also removed various Mono linker source code that is unused.