Delete .NET 5 nuget sources from SetupNugetSources files #9866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArminShoeibi
changed the title
riarenas
previously requested changes
Jul 4, 2022
There was a problem hiding this comment.
Can you give some context on why this change is necessary? The arcade scripts are shared across all of .NET, and the linked PR seems to be only about removing .NET 5 support from runtime? which I don't think means we need to drop support for .net 5 infrastructure everywhere.
mmitche
approved these changes
Oct 19, 2022
riarenas
dismissed
their stale review
We are removing references to these feeds on 7.0 and 8.0 branches, so this can go through now.
|
@ArminShoeibi are you still working on this PR? |
|
This logic was reworked in 5581c96 and from what I can see it'd only add the internal feeds for e.g. dotnet5 if that feed was present in nuget.config, otherwise it is ignored. I don't think this is necessary anymore, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there folks, this PR is related to this PR in dotnet/runtime:
dotnet/runtime#69911 (review)
To double check: