macOS: Show correct arm64 architecture #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvilme
changed the title
Forgind
reviewed
Jan 24, 2025
|
Yes, tested this on an M1 Mac VM with several arm64 and one x64 sdks installed. I'm also ok with performing more tests (installing the x64 version first as it seems to have an effect on the current implementation) beforehand :) |
edvilme
commented
Jan 24, 2025
Comment on lines
+40
to
+43
| DotNetRuntimeInstallPath(EmulatedDotNetInstallPath), | ||
| DotNetAspAllInstallPath(EmulatedDotNetInstallPath), | ||
| DotNetAspAppInstallPath(EmulatedDotNetInstallPath), | ||
| DotNetHostFxrInstallPath(EmulatedDotNetInstallPath))); |
There was a problem hiding this comment.
This was also addressed in #228
Forgind
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #297 #221
When listing runtimes and sdk's on arm Macs, the architecture should be displayed as arm64 instead of x64.
Currently this is not figured out on a by version lookup, but based on the first directory on the sdk installs directory
listdry-run