Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Commit

Permalink
Ensure Sys.Col.Immutable copied to output
Browse files Browse the repository at this point in the history
The code formatter depends on System.Collections.Immutable at runtime to
operate.  This is a value which is not guaranteed to be in the GAC and
hence must be deployed with the tool to ensure it runs correctly.

The easiest way to do this is to ensure it is a part of the build
output.  That way the output directory can be zipped up and deployed
without the need for custom actions.

Unfortunately other tools installed on developers machines were putting
the exact version of System.Collections.Immutable used by the tool into
the GAC.  This caused the MSBuild logic to fail to copy the reference to
the output even if you specified CopyLocal=true.  Making it Private=true
overrides even the GAC exception and the DLL does get copied.

closes #45
  • Loading branch information
jaredpar committed Feb 6, 2015
1 parent 5948268 commit a1d2a92
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/CodeFormatter/CodeFormatter.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
</Reference>
<Reference Include="System" />
<Reference Include="System.Collections.Immutable, Version=1.1.32.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<Private>true</Private>
<HintPath>..\packages\System.Collections.Immutable.1.1.32-beta\lib\portable-net45+win8+wp8+wpa81\System.Collections.Immutable.dll</HintPath>
</Reference>
<Reference Include="System.ComponentModel.Composition" />
Expand Down Expand Up @@ -116,4 +116,4 @@
<Copy SourceFiles="$(ProjectDir)CopyrightHeader.md" DestinationFolder="$(OutDir)" ContinueOnError="true" />
<Copy SourceFiles="$(ProjectDir)MSTestNamespaces.txt" DestinationFolder="$(OutDir)" ContinueOnError="true" />
</Target>
</Project>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
</Reference>
<Reference Include="System" />
<Reference Include="System.Collections.Immutable, Version=1.1.32.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<Private>true</Private>
<HintPath>..\packages\System.Collections.Immutable.1.1.32-beta\lib\portable-net45+win8+wp8+wpa81\System.Collections.Immutable.dll</HintPath>
</Reference>
<Reference Include="System.ComponentModel.Composition" />
Expand Down Expand Up @@ -112,4 +112,4 @@
</Target>
<Target Name="AfterBuild">
</Target>-->
</Project>
</Project>

0 comments on commit a1d2a92

Please sign in to comment.