Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose StreamReader reading from disk in XmlDocReader #2441

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Dispose StreamReader reading from disk in XmlDocReader #2441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/System.CommandLine.DragonFruit/XmlDocReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ public static bool TryLoad(string filePath, out XmlDocReader xmlDocReader)
{
try
{
return TryLoad(File.OpenText(filePath), out xmlDocReader);
using var fileStreamReader = File.OpenText(filePath);
return TryLoad(fileStreamReader, out xmlDocReader);
}
catch
{
Expand Down