API diff between .NET 8 Preview 7 and .NET 8 RC 1 #8757
Conversation
| namespace System.Numerics { | ||
| public static class Vector { | ||
| - public static Vector<T> LoadUnsafe<T>(ref T source); | ||
| + public static Vector<T> LoadUnsafe<T>([RequiresLocationAttribute] ref T source); |
There was a problem hiding this comment.
Can we search/replace all of these [RequiresLocationAttribute] ref with ref readonly? (and subsequently fix the tool accordingly)
There was a problem hiding this comment.
Fixed all the instances with b123b2c and opened an issue: dotnet/arcade#14057
| @@ -0,0 +1,10 @@ | |||
| # System.Buffers | |||
| @@ -0,0 +1,15 @@ | |||
| # System.Numerics | |||
There was a problem hiding this comment.
System.Numerics LGTM.
I agree with Stephen's input that ideally we track [RequiresLocationAttribute] ref as ref readonly, which is the actual language syntax here.
| @@ -0,0 +1,40 @@ | |||
| # System.Runtime.CompilerServices | |||
There was a problem hiding this comment.
System.Runtime.CompilerServices LGTM.
Similar input around ref readonly
| @@ -0,0 +1,39 @@ | |||
| # System.Runtime.Intrinsics | |||
There was a problem hiding this comment.
System.Runtime.Intrinsics LGTM.
Similar input around ref readonly
| @@ -0,0 +1,12 @@ | |||
| # System.Runtime.Intrinsics.Wasm | |||
There was a problem hiding this comment.
CC. @radekdoulik
Were these APIs intentionally removed?
There was a problem hiding this comment.
@radekdoulik @lewing can you take a look?
| ``` diff | ||
| namespace System.Data.Common { | ||
| public abstract class DbBatchCommand { | ||
| + public virtual bool CanCreateParameter { get; } |
Known tooling issues:
{or{}. Please provide a GitHub suggestion in this PR so I can correct it. arcade#10981Repos area owners:
Libraries area owners: