Add known issue for .NET tool restore in .NET 8 RC2 #8799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcpopMSFT
reviewed
Sep 28, 2023
| at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share) | ||
| at NuGet.ProjectModel.LockFileFormat.Write(String filePath, LockFile lockFile) | ||
| at Microsoft.DotNet.Cli.ToolPackage.ToolPackageDownloader.CreateAssetFile(PackageId packageId, NuGetVersion version, DirectoryPath packagesRootPath, DirectoryPath assetFileDirectory, String runtimeJsonGraph, String targetFramework) in C:\git\dotnet-sdk-8\src\Cli\dotnet\ToolPackage\ToolPackageDownloader.cs:line 329 | ||
| at Microsoft.DotNet.Cli.ToolPackage.ToolPackageDownloader.<>c__DisplayClass8_0.<InstallPackage>b__0() in C:\git\dotnet-sdk-8\src\Cli\dotnet\ToolPackage\ToolPackageDownloader.cs:line 130 |
There was a problem hiding this comment.
do we have any standard policy around normalizing paths in error text we include? The path is pretty generic but looks like a local git repo.
There was a problem hiding this comment.
Deterministic builds would result in cutting off the prefix portion of the path and replacing it with /_/ - so we could do that here. Replace all of the c:\git\dotnet-sdk-8 with /_/ and call it good.
Alternatively for purposes of this text we could just remove the paths entirely.
This was referenced Oct 3, 2023
1 task
|
Closing in favor of #8811 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.