Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invalid versions #9441

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Remove invalid versions #9441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02d2733
Remove invalid versions
Falco20019 Aug 9, 2024
9611edb
Re-add 2012 to windows-server-core
Falco20019 Aug 12, 2024
8582cf8
Add 2012 support to .NET 9 windows-server-core
Falco20019 Aug 12, 2024
8480e61
Add 2012-R2 to supported-os of windows-server-core
Falco20019 Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions release-notes/6.0/supported-os.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,6 @@
"11-21h2-e",
"10-21h2-e-lts",
"10-21h2-iot-lts",
"10-20h2-e-lts",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows 10 20H2 was only a semi-anual version and never a LTS. Therefore there was also no information on EndOfLife.date.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Not sure what happened there. Likely a copy/paste error.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't 10-20h2-e and 10-20h2-2 be added to the unsupported list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10-20h2-e and 10-20h2-w are already on the unsupported list. Not sure what you mean by 10-20h2-2.

"10-1809-e-lts",
"10-1607-e-lts"
],
Expand Down Expand Up @@ -393,10 +392,10 @@
"x86"
],
"supported-versions": [
"23H2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://mcr.microsoft.com/en-us/product/windows/servercore and https://learn.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/base-image-lifecycle there was never a release of 23H2 or 2012.

Copy link
Contributor Author

@Falco20019 Falco20019 Aug 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And besides https://learn.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/base-image-lifecycle stating that 1607 is only Semi-Anual and released on Nano Server, whereas 2016 is the only Long-Term on Server Core:
image

https://mcr.microsoft.com/en-us/product/windows/servercore shows that it's instead handled like the Server-Core case with 2019 and 1809:
image

So in my opinion, https://learn.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/base-image-lifecycle should be fixed to be like this:
image

If 1607 and 1809 are considered LTSC as well, we should update the EOL dates on https://endoflife.date/windows-server-core as well to show they are still maintained (as shown by the image tags on MCR). As of now, both are considered EOL while the LTSC variants are supported:
image
image

Copy link
Member

@richlander richlander Aug 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server 2012: https://learn.microsoft.com/en-us/lifecycle/products/windows-server-2012

Containers started with 2016, so the container-related lifecycle page is providing a partial view of Windows Server lifecycle.

Copy link
Contributor Author

@Falco20019 Falco20019 Aug 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But since there are no images available, there is nothing to have support for 🤔 Or did there exist a non-containered installation option for 2012? In that case, I will re-add it here and have EoL.dates updated.

Copy link
Contributor Author

@Falco20019 Falco20019 Aug 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I found https://learn.microsoft.com/en-us/previous-versions/windows/desktop/legacy/hh846313(v=vs.85) so I missed to add 2012 to EoL.date.

Will have a PR there and fix it here tomorrow once in office.

"2022",
"2019",
"2016",
"2012-R2",
"2012"
],
"unsupported-versions": [
Expand Down
4 changes: 3 additions & 1 deletion release-notes/7.0/supported-os.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,9 @@
"supported-versions": [
"2022",
"2019",
"2016"
"2016",
"2012-R2",
"2012"
]
}
]
Expand Down
2 changes: 1 addition & 1 deletion release-notes/8.0/supported-os.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,10 +316,10 @@
"x86"
],
"supported-versions": [
"23H2",
"2022",
"2019",
"2016",
"2012-R2",
"2012"
]
}
Expand Down
5 changes: 3 additions & 2 deletions release-notes/9.0/supported-os.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,10 +294,11 @@
"x86"
],
"supported-versions": [
"23H2",
"2022",
"2019",
"2016"
"2016",
"2012-R2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm asking for insight on 2012/R2 on .NET 9 support, from @jamshedd.

Copy link
Contributor Author

@Falco20019 Falco20019 Aug 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for 2008/R2 then since it's in ESU4: https://learn.microsoft.com/de-de/lifecycle/products/windows-server-2008-r2
Was never listed as supported in the past (also not on the markdown before having the JSON).

Copy link
Member

@richlander richlander Aug 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got confirmation that we still support 2012/R2, including for .NET 9. It was the lowest Server OS we've supported, so no need to add 2008.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about 2008 is still open.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was saying it is correct that 2008 was never listed. We never supported it, so it should not be in either supported or unsupported lists. This one isn't a function of ESU. It's that we don't test it and it may not work. We do test Server 2012.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification. Then this should be fine. EoL.date was merged, so I will have another run of distrossed and the core-support tooling to see if any more might be off. But should be fine to merge otherwise :)

"2012"
]
}
]
Expand Down
Loading