Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix supported-os.{md,json} #9481

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Conversation

Falco20019
Copy link
Contributor

@Falco20019 Falco20019 commented Aug 23, 2024

Contributes to #9417 and includes generated parts similar to #9479. So I would recommend doing this PR after #9479 is merged to reduce the change-set in the PR.

  • Moved Debian 11 from supported to unsupported on .NET 6, 7, 8
  • Moved RHEL 7 from supported to unsupported on .NET 6, 7
  • Moved Ubuntu 23.10 from supported to unsupported on .NET 6, 7, 8
  • Added SUSE Enterprise Linux 12.5 to supported on .NET 8
  • Added SUSE Enterprise Linux 15.4 to unsupported on .NET 8
  • Moved SUSE Enterprise Linux 15.4 from supported to unsupported on .NET 7
  • Added SUSE Enterprise Linux 15.6 to supported on .NET 6, 8, 9
  • Regenerated supported-os.md which also fixed Windows Server Core entries (already in Update 9.0 OS Packages #9479)

I did update .NET 7 even though technically not required since it's EOL anyway. Just did it to also see if I covered everything in my adjusted distroessed tooling. If you like to keep it on the old state, I can revert the changes. I did not add any new versions like SLES 15.6 to .NET 7 of course :)

I compared all versions to the last-before-being-generated ones and according to https://github.com/dotnet/core/blob/56290a0acf2e15e4aa8b0ffa0a02f41501fc088e/release-notes/8.0/supported-os.md we seem to have dropped SLES some versions on .NET 8 (which I re-added here).

/CC @richlander @leecow @omajid

@Falco20019 Falco20019 changed the title Fix version Fix supported-os.{md,json} Aug 23, 2024
@richlander
Copy link
Member

Can you add Debian 11 to supported for .NET 6? It is unfortunate, but we're forced to continue shipping Debian 11 images until .NET 6 EOL. We will have this same problem with .NET 8 (with Debian 12) but won't repeat it after that. Context: dotnet/dotnet-docker#5710.

@richlander
Copy link
Member

For .NET 7 (and any other EOL version), the intent is to leave the information as accurate at the time of EOL, so that we have a historical document. IMO, it is harmful to end up with a document that says "no OSes supported". What's useful is to know which OSes .NET 7 was supported on (at EOL), for historical interest, 5 years from now.

So, it is fine to continue to update the .NET 7 document as long as we're making it accurate to that goal. We shouldn't move OSes to unsupported that were supported at EOL.

@richlander
Copy link
Member

PR looks good, other than the w comments I made. Thanks!

@Falco20019
Copy link
Contributor Author

Will do it on Monday since I‘m out of office for the weekend and doing it by mobile isn‘t that confy if that‘s early enough for you :)

@richlander
Copy link
Member

Monday is more than early enough! I hope you enjoy your time away.

@Falco20019
Copy link
Contributor Author

Falco20019 commented Aug 26, 2024

Thanks for the clarification. I re-checked .NET 7 and the document was correct to the state of EOL (no missing OS in JSON). So I reverted it back to the state before and only regenerated the MD files to fix the missing WinServ 2012(R2) OS that you already considered with #9479.

I also added the exceptions for Debian 11 and 12 to richlander/distroessed#8 to not get confused in the future again :) I moved Debian 11 back to supported and updated the initial post to clarify that.

It will be great to move those exceptions into a separate JSON (or as additional data block(s) in the supported-os.json since the JSON Schema is not published as of now).

@Falco20019
Copy link
Contributor Author

@richlander I created two PRs showing how the exceptional versions COULD be maintained in the supported-os.json if we want to add it into there. We could of-course also maintain it in a separate JSON, but since the schemas are not finalized yet, it might be better to not duplicate the main-structure.

Copy link
Member

@richlander richlander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@richlander richlander merged commit d934121 into dotnet:main Aug 26, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants