fix: PDF Header/Footer pages size #10100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yufeih
added
the
bug-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intended to fix pdf footer problem reported at #10087
Background
PDF header/footer pages are separately generated from content page PDF. and merged with content pages.
And currently header/footer pages always using default
Letterpage size.So when using custom page size. header/footer is displayed on wrong locations.
This PR change logics to use
Content Page PDF's page size for header/footer page generation.Test
I've confirmed it works as expected with following page sizes.
size: A4 portrait;size: A4 landscape;size: 460mm 220mm(Custom size)size: 220mm 460mm(Custom size)