Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code fix 1678 #1704

Merged
merged 18 commits into from
Oct 10, 2023
Merged

Code fix 1678 #1704

merged 18 commits into from
Oct 10, 2023

Conversation

adegeo
Copy link
Contributor

@adegeo adegeo commented Sep 21, 2023

  • Rewrote the intro note and the Overview and the dispatcher section to focus on InvokeAsync instead of BeginInvoke.
  • Rewrote the code for the 3 examples.
  • Minor touchups to wording, but I didn't rewrite the article.
  • New screenshots; kept old diagrams

Fixes #1691
Fixes #1678


Internal previews

📄 File 🔗 Preview link
dotnet-desktop-guide/framework/wpf/advanced/threading-model.md Threading Model

@adegeo adegeo marked this pull request as ready for review October 10, 2023 15:02
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, otherwise looks good!

@adegeo adegeo merged commit d8ac7d2 into main Oct 10, 2023
8 checks passed
@adegeo adegeo deleted the code-fix-1678 branch October 10, 2023 20:40
@Micke3rd
Copy link

Micke3rd commented Oct 20, 2023

However, notice that await Task.Run is used.

Hi @adegeo , but Task.Run is not used in the description nor in the code.

@adegeo
Copy link
Contributor Author

adegeo commented Oct 24, 2023

@Micke3rd Ack yes... And some other variables were changed via the feedback that weren't changed in the description. I'll run through the article and fix these up.

@Micke3rd
Copy link

Micke3rd commented Oct 24, 2023

regardless of this typo, thank you especially for the samples\wpf\Threading\MultithreadedWindow example, didn't know this is possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants