Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update listview-overview.md #1709

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Update listview-overview.md #1709

merged 2 commits into from
Oct 17, 2023

Conversation

SamHobbsOrg
Copy link
Contributor

@SamHobbsOrg SamHobbsOrg commented Oct 8, 2023

Minor grammatical improvements.

Summary

Describe your changes here.

Fixes #Issue_Number (if available)


Internal previews

📄 File 🔗 Preview link
dotnet-desktop-guide/framework/wpf/controls/listview-overview.md ListView Overview

Minor grammatical improvements.
@adegeo
Copy link
Contributor

adegeo commented Oct 11, 2023

Hi @SamHobbsOrg I appreciate your effort here. However, I don't see how this really clarifies or improves the content?

@adegeo adegeo added the needs-more-info Needs more info from OP. Auto-closed after 2 weeks if no response. [org][resolution] label Oct 11, 2023
@SamHobbsOrg
Copy link
Contributor Author

No technical improvements. It is grammatical improvements.

@github-actions github-actions bot removed the needs-more-info Needs more info from OP. Auto-closed after 2 weeks if no response. [org][resolution] label Oct 11, 2023
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! A few minor changes to consider.

@adegeo adegeo added the needs-more-info Needs more info from OP. Auto-closed after 2 weeks if no response. [org][resolution] label Oct 11, 2023
@adegeo
Copy link
Contributor

adegeo commented Oct 16, 2023

@SamHobbsOrg If you're OK with it, I can implement the suggestion I made directly into this PR for you.

@SamHobbsOrg
Copy link
Contributor Author

Go ahead with whatever changes you decide on.

@github-actions github-actions bot removed the needs-more-info Needs more info from OP. Auto-closed after 2 weeks if no response. [org][resolution] label Oct 17, 2023
@adegeo
Copy link
Contributor

adegeo commented Oct 17, 2023

@SamHobbsOrg Thanks again for this contribution!

@adegeo adegeo enabled auto-merge (squash) October 17, 2023 22:15
@adegeo adegeo merged commit 2932942 into dotnet:main Oct 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants