Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feedback system to new github issues format #1711

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Conversation

adegeo
Copy link
Contributor

@adegeo adegeo commented Oct 10, 2023

Summary

@homing1 please review the docfx file. I copied the settings from the dotnet/docs repo, from a PR you contributed to.

@adegeo adegeo marked this pull request as ready for review October 10, 2023 22:40
@adegeo adegeo requested a review from homing1 October 10, 2023 22:40
@homing1
Copy link

homing1 commented Oct 10, 2023

@adegeo The metadata properties look good to me, but I don't have feedback on their values as I don't know what values are appropriate for this repo. open_source_feedback_issueTitle is optional. You can leave it as is, or you can omit it if you don't want a default title for the issue form.

You can preview it with this link: https://review.learn.microsoft.com/en-us/dotnet/desktop/winforms/whats-new/net70?view=netdesktop-7.0&branch=pr-en-us-1711

The Open a documentation issue link won't work properly until the issue template that you're adding in this PR is merged.

@adegeo
Copy link
Contributor Author

adegeo commented Oct 11, 2023

Thanks @homing1

@adegeo adegeo merged commit c019b1d into main Oct 11, 2023
6 checks passed
@adegeo adegeo deleted the adegeo-feedbacksystem branch October 11, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants