Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Exclam from SiteName or add note. #44198

Closed
gregoryagu opened this issue Jan 9, 2025 · 4 comments
Closed

Remove Exclam from SiteName or add note. #44198

gregoryagu opened this issue Jan 9, 2025 · 4 comments

Comments

@gregoryagu
Copy link
Contributor

gregoryagu commented Jan 9, 2025

Type of issue

Code doesn't work

Description

I created a test project and ran the code exactly as provided. The validation fails. After some debugging, it turns out the exclamation mark does not pass the regular expression, and so fails the validation.

I would recommend you either remove the exclamation mark, or add a note saying that the validation will fail due to the exclamation mark to make this clearer if it was intentional.

"MyCustomSettingsSection": { "SiteTitle": "Amazing docs from awesome people!", "Scale": 10, "VerbosityLevel": 32 },

Page URL

https://learn.microsoft.com/en-us/dotnet/core/extensions/options-validation-generator

Content source URL

https://github.com/dotnet/docs/blob/main/docs/core/extensions/options-validation-generator.md

Document Version Independent Id

0775474e-7773-d061-ed21-0a360c8466b1

Article author

@tarekgh

Metadata

  • ID: 533f4fc6-bb7c-874d-6639-ea215af95ed3
  • Service: dotnet-fundamentals

Related Issues

@dotnet-policy-service dotnet-policy-service bot added the ⌚ Not Triaged Not triaged label Jan 9, 2025
@tarekgh tarekgh added this to the May 2025 milestone Jan 9, 2025
@tarekgh
Copy link
Member

tarekgh commented Jan 9, 2025

@gregoryagu are you interested to submit a PR for that?

@gregoryagu
Copy link
Contributor Author

Yes, would be happy to!

@gregoryagu
Copy link
Contributor Author

I have created the pull request: #44202

@tarekgh
Copy link
Member

tarekgh commented Jan 14, 2025

This is now fixed by #44202

@tarekgh tarekgh closed this as completed Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants