Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SettingsOptions.cs #44202

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Update SettingsOptions.cs #44202

merged 1 commit into from
Jan 9, 2025

Conversation

gregoryagu
Copy link
Contributor

@gregoryagu gregoryagu commented Jan 9, 2025

Summary

Changed the Regular Expression to allow an exclamation mark which is used in the sample code. The existing Regular Expression allowed a dash which was not used in the sample. I replaced the dash with the exclamation mark. The sample code will now run as is, instead of throwing an exception. I have tested the updated Regular Expression, and it is working as expected.

Fixes 44198

Changed the Regular Expression to allow an exclamation mark which is used in the sample code.  The existing Regular Expression allowed a dash which was not used in the sample.  I replaced the dash with the exclamation mark. The sample code will now run as is, instead of throwing an exception.  I have tested the updated Regular Expression, and it is working as expected.
@gregoryagu gregoryagu requested review from IEvangelist and a team as code owners January 9, 2025 19:55
@dotnetrepoman dotnetrepoman bot added this to the January 2025 milestone Jan 9, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-fundamentals/svc community-contribution Indicates PR is created by someone from the .NET community. labels Jan 9, 2025
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gregoryagu!

@tarekgh tarekgh enabled auto-merge (squash) January 9, 2025 20:42
@tarekgh tarekgh merged commit 734664e into dotnet:main Jan 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants