Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for new SqlTypes APIs #8421

Merged
merged 6 commits into from
Sep 26, 2022
Merged

Add docs for new SqlTypes APIs #8421

merged 6 commits into from
Sep 26, 2022

Conversation

David-Engel
Copy link
Contributor

Summary

Related to:
dotnet/runtime#72724
dotnet/runtime#51836

Partially addresses: dotnet/runtime#76049

@ghost
Copy link

ghost commented Sep 23, 2022

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

Related to:
dotnet/runtime#72724
dotnet/runtime#51836

Partially addresses: dotnet/runtime#76049

Author: David-Engel
Assignees: David-Engel
Labels:

area-System.Data

Milestone: -

@opbld30
Copy link

opbld30 commented Sep 23, 2022

Docs Build status updates of commit 142462f:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren
Copy link
Contributor

Close/reopen for build.

@gewarren gewarren closed this Sep 23, 2022
@gewarren gewarren reopened this Sep 23, 2022
@opbld30
Copy link

opbld30 commented Sep 23, 2022

Docs Build status updates of commit 142462f:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details
xml/System.Data.SqlTypes/SqlBinary.xml ❌Error Details

  • Line 0, Column 0: [Error: ECMA2Yaml_File_LoadFailed] Failed to load 1 files, aborting...

xml/System.Data.SqlTypes/SqlBinary.xml

  • Line 0, Column 0: [Error: ECMA2Yaml_InternalError]
Intenal Several Error: System.Xml.XmlException: The 'format' start tag on line 1927 position 12 does not match the end tag of 'remarks'. Line 1932, position 7.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String[] args)
   at System.Xml.XmlTextReaderImpl.ThrowTagMismatch(NodeData startTag)
   at System.Xml.XmlTextReaderImpl.ParseEndElement()
   at System.Xml.XmlTextReaderImpl.ParseElementContent()
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)
   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
   at System.Xml.Linq.XDocument.Parse(String text, LoadOptions options)
   at ECMA2Yaml.ECMALoader.LoadType(FileItem typeFile)
   at ECMA2Yaml.ECMALoader.LoadTypes(String basePath, Namespace ns)

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld32
Copy link

opbld32 commented Sep 23, 2022

Docs Build status updates of commit 915e64c:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Data.SqlTypes/SqlDecimal.xml ⚠️Warning View Details
xml/System.Data.SqlTypes/SqlBinary.xml 💡Suggestion View Details
xml/System.Data.SqlTypes/SqlMoney.xml ✅Succeeded View

xml/System.Data.SqlTypes/SqlDecimal.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Span'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Span'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Span'.

xml/System.Data.SqlTypes/SqlBinary.xml

  • Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'see' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld32
Copy link

opbld32 commented Sep 23, 2022

Docs Build status updates of commit 1c84374:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Data.SqlTypes/SqlBinary.xml ✅Succeeded View
xml/System.Data.SqlTypes/SqlDecimal.xml ✅Succeeded View
xml/System.Data.SqlTypes/SqlMoney.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld33
Copy link

opbld33 commented Sep 23, 2022

Docs Build status updates of commit 61af215:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Data.SqlTypes/SqlBinary.xml ✅Succeeded View
xml/System.Data.SqlTypes/SqlDecimal.xml ✅Succeeded View
xml/System.Data.SqlTypes/SqlMoney.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

xml/System.Data.SqlTypes/SqlBinary.xml Outdated Show resolved Hide resolved
xml/System.Data.SqlTypes/SqlDecimal.xml Outdated Show resolved Hide resolved
xml/System.Data.SqlTypes/SqlMoney.xml Outdated Show resolved Hide resolved
Co-authored-by: Genevieve Warren <[email protected]>
@opbld31

This comment was marked as outdated.

@opbld32
Copy link

opbld32 commented Sep 26, 2022

Docs Build status updates of commit a3c8cc3:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Data.SqlTypes/SqlBinary.xml ✅Succeeded View
xml/System.Data.SqlTypes/SqlDecimal.xml ✅Succeeded View
xml/System.Data.SqlTypes/SqlMoney.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren merged commit 0d18592 into dotnet:main Sep 26, 2022
@David-Engel David-Engel deleted the sqltypes branch September 27, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Data Data APIs (ADO.NET, XML, etc).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants