Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Markdown linter GH action #5762

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

MichaelSimons
Copy link
Member

@MichaelSimons MichaelSimons commented Aug 7, 2024

Related to #5316

This initial set of changes just adds the linter action but disables numerous rules. Once enabled I will open follow-up PRs to address the syntax violations.

The linter action was copied from dotnet/runtime.

@lbussell
Copy link
Contributor

lbussell commented Aug 7, 2024

Related to #531

This doesn't appear to be the correct link.

Will you file an issue to track cleaning up the linting report?

@lbussell
Copy link
Contributor

lbussell commented Aug 7, 2024

Also, is it possible for the linter to run on this PR? Or do actions need to be enabled first?

@MichaelSimons
Copy link
Member Author

Related to #531

This doesn't appear to be the correct link.

I fixed the description. The issue is #5316.

Will you file an issue to track cleaning up the linting report?

I was going keep the issue open and use it.

@MichaelSimons
Copy link
Member Author

Also, is it possible for the linter to run on this PR? Or do actions need to be enabled first?

Not that I am aware of. I have tested it in my fork.

@MichaelSimons
Copy link
Member Author

MichaelSimons commented Aug 7, 2024

Also, is it possible for the linter to run on this PR? Or do actions need to be enabled first?

Not that I am aware of. I have tested it in my fork.

I should note, once merged, updates to the action are picked up/tested in the PR itself.

@MichaelSimons MichaelSimons merged commit ef85b41 into dotnet:main Aug 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants