-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable testing of internal servicing builds #5928
Open
NikolaMilosavljevic
wants to merge
15
commits into
dotnet:main
Choose a base branch
from
NikolaMilosavljevic:int.test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ecdce4c
Enable dependency and dockerfile updates for internal builds
NikolaMilosavljevic 9cd8547
Dockerfile support for internal builds
NikolaMilosavljevic 0eda96e
Pipeline changes for internal testing
NikolaMilosavljevic 3dfae62
Test infra changes for internal testing
NikolaMilosavljevic 042d5f1
Remove unnecessary variables
NikolaMilosavljevic 11e0151
Remove unused url-suffix references
NikolaMilosavljevic a44b4c0
Revert unwanted dry-run
NikolaMilosavljevic a930c7b
Remove isInternalServicingValidation parameter from templates not use…
NikolaMilosavljevic 21ede77
Obtain token if not provided
NikolaMilosavljevic b87ee96
Fix indentation
NikolaMilosavljevic 1f57830
Update internal url check
NikolaMilosavljevic 887e9fd
Remove unused parameters
NikolaMilosavljevic f6cf4a1
Follow up on removing unneeded parameters
NikolaMilosavljevic f9700ce
Cleanup naming
NikolaMilosavljevic cfa5c30
Fix a bug in aspnet templates
NikolaMilosavljevic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
BlobStorageSasQueryString
parameter is obsolete now and should be removed. This applies more broadly too. Do a search for "SasQueryString" in the repo and you'll find a lot of occurrences which all need to get cleaned up since this new implementation is replacing that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with f9700ce