use switch for SqlServerDateOnlyMemberTranslator #34417
Open
+23
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but if we're doing to do this, it would be better to do it across the board and not just in one translator - are you interested in doing that? |
yep. but i wasnt sure on how large you like PRs to be? |
|
As long as it does only this one change, I think it's fine for it to be as big as it needs to be... I'd maybe do a pass on the translators only for now (though there probably are similar opportunities elsewhere) to keep the scope manageable. FWIW this is something that I've been wanting to do for a while... |
roji
reviewed
Aug 14, 2024
| }; | ||
| } | ||
|
|
||
| private SqlExpression Function(SqlExpression? instance, Type returnType, string datePart) |
There was a problem hiding this comment.
nit: move this inside to be a local method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #34413
@roji