Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Eventually) fix #17501 #17668

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
ea8e5e2
wip
vzarytovskii Sep 6, 2024
e3531b1
wip
vzarytovskii Sep 6, 2024
4e9db64
wip
vzarytovskii Sep 6, 2024
149867a
wip
vzarytovskii Sep 6, 2024
c41ef57
wip
vzarytovskii Sep 6, 2024
fcf0fa4
wip
vzarytovskii Sep 6, 2024
ef35896
wip
vzarytovskii Sep 6, 2024
05f3ff9
wip
vzarytovskii Sep 6, 2024
565cbf4
wip
vzarytovskii Sep 6, 2024
e790276
Merge branch 'main' into fix-17501
vzarytovskii Sep 9, 2024
5373a55
Merge branch 'main' into fix-17501
vzarytovskii Sep 9, 2024
e4a3510
wip
vzarytovskii Sep 18, 2024
3168d95
wip
vzarytovskii Sep 18, 2024
1b2b165
wip
vzarytovskii Sep 18, 2024
8a8b23c
Merge branch 'main' into fix-17501
vzarytovskii Sep 18, 2024
707c442
wip
vzarytovskii Sep 19, 2024
7a2fa82
wip
vzarytovskii Sep 19, 2024
424f5dd
wip
vzarytovskii Sep 19, 2024
9d4339a
wip
vzarytovskii Sep 19, 2024
44107e6
wip
vzarytovskii Sep 19, 2024
3004d7e
wip
vzarytovskii Sep 19, 2024
8a8056f
wip
vzarytovskii Sep 20, 2024
37ee216
wip
vzarytovskii Sep 20, 2024
73e3101
wip
vzarytovskii Sep 20, 2024
9a65fd6
wip
vzarytovskii Sep 20, 2024
14c1474
Merge remote-tracking branch 'upstream/main' into fix-17501
vzarytovskii Sep 23, 2024
021dbe6
wip
vzarytovskii Sep 23, 2024
e9f954b
wip
vzarytovskii Sep 23, 2024
498e52e
wip
vzarytovskii Sep 23, 2024
b771157
wip
vzarytovskii Sep 23, 2024
f4d1678
wip
vzarytovskii Sep 23, 2024
aabb93f
wip
vzarytovskii Sep 25, 2024
e1d0e9a
Automated command ran: fantomas
github-actions[bot] Sep 25, 2024
e681f69
Merge branch 'main' into fix-17501
vzarytovskii Sep 25, 2024
ffca5bd
wip
vzarytovskii Sep 25, 2024
95f3605
wip
vzarytovskii Sep 25, 2024
0e6afe2
wip
vzarytovskii Sep 25, 2024
81f2145
wip
vzarytovskii Sep 25, 2024
f5047d8
Comments
vzarytovskii Sep 30, 2024
f95583d
Merge branch 'main' into fix-17501
vzarytovskii Sep 30, 2024
16d764a
Merge remote-tracking branch 'upstream/main' into fix-17501
vzarytovskii Oct 14, 2024
eaee661
Fantomas
vzarytovskii Oct 14, 2024
cc675be
Revert some unnecesasry changes around seq
vzarytovskii Oct 14, 2024
b6f209e
Fix typehashing
vzarytovskii Oct 14, 2024
c2830f5
Merge branch 'main' into fix-17501
vzarytovskii Oct 29, 2024
98372b9
Update import.fs
vzarytovskii Oct 29, 2024
fa1b4bc
Update src/Compiler/Checking/import.fs
vzarytovskii Oct 29, 2024
2ea62d2
Update
vzarytovskii Oct 29, 2024
649494a
changelog
vzarytovskii Oct 29, 2024
2b27cd7
changelog
vzarytovskii Oct 29, 2024
30b312c
Merge branch 'main' into fix-17501
vzarytovskii Oct 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/release-notes/.FSharp.Compiler.Service/9.0.200.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,11 @@
* Fix nullness inference for member val and other OO scenarios ([PR #17845](https://github.com/dotnet/fsharp/pull/17845))
* Fix internal error when analyzing incomplete inherit member ([PR #17905](https://github.com/dotnet/fsharp/pull/17905))


### Added

* Deprecate places where `seq` can be omitted. ([Language suggestion #1033](https://github.com/fsharp/fslang-suggestions/issues/1033), [PR #17772](https://github.com/dotnet/fsharp/pull/17772))
* Support literal attribute on decimals ([PR #17769](https://github.com/dotnet/fsharp/pull/17769))
* Added type conversions cache, only enabled for compiler runs, guarded by language version preview ([PR#17668](https://github.com/dotnet/fsharp/pull/17668))

### Changed

Expand Down
1 change: 1 addition & 0 deletions docs/release-notes/.Language/preview.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

* Better generic unmanaged structs handling. ([Language suggestion #692](https://github.com/fsharp/fslang-suggestions/issues/692), [PR #12154](https://github.com/dotnet/fsharp/pull/12154))
* Deprecate places where `seq` can be omitted. ([Language suggestion #1033](https://github.com/fsharp/fslang-suggestions/issues/1033), [PR #17772](https://github.com/dotnet/fsharp/pull/17772))
* Added type conversions cache, only enabled for compiler runs ([PR#17668](https://github.com/dotnet/fsharp/pull/17668))

### Fixed

Expand Down
1 change: 1 addition & 0 deletions src/Compiler/Checking/Expressions/CheckExpressions.fs
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ open FSharp.Compiler.TypedTreeBasics
open FSharp.Compiler.TypedTreeOps
open FSharp.Compiler.TypeHierarchy
open FSharp.Compiler.TypeRelations
open Import
vzarytovskii marked this conversation as resolved.
Show resolved Hide resolved

#if !NO_TYPEPROVIDERS
open FSharp.Compiler.TypeProviders
Expand Down
1 change: 1 addition & 0 deletions src/Compiler/Checking/InfoReader.fs
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ open FSharp.Compiler.TypedTreeOps
open FSharp.Compiler.TypedTreeBasics
open FSharp.Compiler.TypeHierarchy
open FSharp.Compiler.TypeRelations
open Import

/// Use the given function to select some of the member values from the members of an F# type
let SelectImmediateMemberVals g optFilter f withExplicitImpl (tcref: TyconRef) =
Expand Down
1 change: 1 addition & 0 deletions src/Compiler/Checking/MethodOverrides.fs
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ exception TypeIsImplicitlyAbstract of range
exception OverrideDoesntOverride of DisplayEnv * OverrideInfo * MethInfo option * TcGlobals * Import.ImportMap * range

module DispatchSlotChecking =
open Import

/// Print the signature of an override to a buffer as part of an error message
let PrintOverrideToBuffer denv os (Override(_, _, id, methTypars, memberToParentInst, argTys, retTy, _, _, _)) =
Expand Down
4 changes: 2 additions & 2 deletions src/Compiler/Checking/NicePrint.fs
Original file line number Diff line number Diff line change
Expand Up @@ -2045,7 +2045,7 @@ module TastDefinitionPrinting =
(not vref.IsCompilerGenerated) &&
(denv.showObsoleteMembers || not (CheckFSharpAttributesForObsolete denv.g vref.Attribs)) &&
(denv.showHiddenMembers || not (CheckFSharpAttributesForHidden denv.g vref.Attribs))

let ctors =
GetIntrinsicConstructorInfosOfType infoReader m ty
|> List.filter (fun minfo -> IsMethInfoAccessible amap m ad minfo && not minfo.IsClassConstructor && shouldShow minfo.ArbitraryValRef)
Expand All @@ -2057,7 +2057,7 @@ module TastDefinitionPrinting =
tycon.ImmediateInterfacesOfFSharpTycon
|> List.filter (fun (_, compgen, _) -> not compgen)
|> List.map p13
else
else
GetImmediateInterfacesOfType SkipUnrefInterfaces.Yes g amap m ty

let iimplsLs =
Expand Down
1 change: 1 addition & 0 deletions src/Compiler/Checking/PatternMatchCompilation.fs
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ open FSharp.Compiler.TypedTreeOps
open FSharp.Compiler.TypedTreeOps.DebugPrint
open FSharp.Compiler.TypeRelations
open type System.MemoryExtensions
open Import

exception MatchIncomplete of bool * (string * bool) option * range
exception RuleNeverMatched of range
Expand Down
Loading
Loading