Some more assorted tests improvements #17931
Open
+114
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
majocha
commented
Oct 28, 2024
tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncModule.fs
Show resolved
Hide resolved
majocha
commented
Oct 28, 2024
tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/Cancellation.fs
Show resolved
Hide resolved
majocha
commented
Oct 28, 2024
majocha
commented
Oct 28, 2024
psfinaki
reviewed
Oct 29, 2024
| @@ -1027,11 +1028,12 @@ type ProjectWorkflowBuilder | |||
|
|
|||
| member this.Execute(workflow: Async<WorkflowContext>) = | |||
| try | |||
| Async.RunSynchronously(workflow, timeout = defaultArg runTimeout 600_000) | |||
| // We don't want the defaultCancellationToken. | |||
There was a problem hiding this comment.
For reference, it would be nice to specify the reason why :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more assorted tests improvements extracted from #17872