Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more assorted tests improvements #17931

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Oct 28, 2024

Some more assorted tests improvements extracted from #17872

@majocha majocha requested a review from a team as a code owner October 28, 2024 10:23
Copy link
Contributor

✅ No release notes required

@@ -1027,11 +1028,12 @@ type ProjectWorkflowBuilder

member this.Execute(workflow: Async<WorkflowContext>) =
try
Async.RunSynchronously(workflow, timeout = defaultArg runTimeout 600_000)
// We don't want the defaultCancellationToken.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, it would be nice to specify the reason why :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants