Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix :: Nullness in signature file is not considered by implementation and vice versa #18186

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from

apply

c1991ce
Select commit
Loading
Failed to load commit list.
Draft

Bugfix :: Nullness in signature file is not considered by implementation and vice versa #18186

apply
c1991ce
Select commit
Loading
Failed to load commit list.
Azure Pipelines / fsharp-ci (Build MockOfficial) failed Jan 10, 2025 in 7m 22s

Build MockOfficial failed

61 errors / 0 warnings

Annotations

Check failure on line 1006 in src\Compiler\TypedTree\TypeProviders.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build MockOfficial)

src\Compiler\TypedTree\TypeProviders.fs#L1006 

src\Compiler\TypedTree\TypeProviders.fs(1006,14): error FS0034: (NETCORE_ENGINEERING_TELEMETRY=Build) Module 'FSharp.Compiler.TypeProviders' contains    member TypeProviders.ProvidedExpr.UnderlyingExpressionString: string with internal get    but its signature specifies    member TypeProviders.ProvidedExpr.UnderlyingExpressionString: string Internal.Utilities.Library.NullnessShims.MaybeNull with internal get    The types differ

Check failure on line 617 in src\Compiler\TypedTree\TypeProviders.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build MockOfficial)

src\Compiler\TypedTree\TypeProviders.fs#L617 

src\Compiler\TypedTree\TypeProviders.fs(617,14): error FS0034: (NETCORE_ENGINEERING_TELEMETRY=Build) Module 'FSharp.Compiler.TypeProviders' contains    member TypeProviders.ProvidedParameterInfo.RawDefaultValue: obj with internal get    but its signature specifies    member TypeProviders.ProvidedParameterInfo.RawDefaultValue: objnull with internal get    The types differ

Check failure on line 379 in src\Compiler\TypedTree\TypeProviders.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build MockOfficial)

src\Compiler\TypedTree\TypeProviders.fs#L379 

src\Compiler\TypedTree\TypeProviders.fs(379,14): error FS0034: (NETCORE_ENGINEERING_TELEMETRY=Build) Module 'FSharp.Compiler.TypeProviders' contains    member TypeProviders.ProvidedType.FullName: string with internal get    but its signature specifies    member TypeProviders.ProvidedType.FullName: string Internal.Utilities.Library.NullnessShims.MaybeNull with internal get    The types differ

Check failure on line 471 in src\Compiler\TypedTree\TypeProviders.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build MockOfficial)

src\Compiler\TypedTree\TypeProviders.fs#L471 

src\Compiler\TypedTree\TypeProviders.fs(471,14): error FS0034: (NETCORE_ENGINEERING_TELEMETRY=Build) Module 'FSharp.Compiler.TypeProviders' contains    member internal TypeProviders.ProvidedType.MakeGenericType: args: TypeProviders.ProvidedType array -> TypeProviders.ProvidedType Internal.Utilities.Library.NullnessShims.MaybeNull    but its signature specifies    member internal TypeProviders.ProvidedType.MakeGenericType: args: TypeProviders.ProvidedType array Internal.Utilities.Library.NullnessShims.MaybeNull -> TypeProviders.ProvidedType Internal.Utilities.Library.NullnessShims.MaybeNull    The types differ

Check failure on line 804 in src\Compiler\TypedTree\TypeProviders.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build MockOfficial)

src\Compiler\TypedTree\TypeProviders.fs#L804 

src\Compiler\TypedTree\TypeProviders.fs(804,14): error FS0034: (NETCORE_ENGINEERING_TELEMETRY=Build) Module 'FSharp.Compiler.TypeProviders' contains    member internal TypeProviders.ProvidedFieldInfo.GetRawConstantValue: unit -> obj    but its signature specifies    member internal TypeProviders.ProvidedFieldInfo.GetRawConstantValue: unit -> obj Internal.Utilities.Library.NullnessShims.MaybeNull    The types differ
View more details on Azure Pipelines