-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Tabs does not invoke its IQueryAttributable.ApplyQueryAttributes(query) #25663
Draft
SuthiYuvaraj
wants to merge
18
commits into
dotnet:main
Choose a base branch
from
SuthiYuvaraj:fix-13573
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+288
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @SuthiYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
SuthiYuvaraj
changed the title
Fix 13573
Fix for Tabs does not invoke its IQueryAttributable.ApplyQueryAttributes(query)
Nov 4, 2024
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details
While navigating between pages, ApplyQueryAttributes should trigger with data from the navigating page. In the current implementation, navigation using Push and GoToAsync works as expected, but other navigation methods do not trigger ApplyQueryAttributes notifications.
Root Cause
-GoToAsync Limitations: When navigating using PopAsync, PopModalAsync, back navigation, or between FlyoutPages, ApplyQueryAttributes is not triggered. This occurs because QueryAttributes is not correctly set for these navigation types.
-TabBar Navigation: Navigating between TabBar items changes the page by updating CurrentItemChanged. However, QueryAttributes is not updated for these item changes, leading to missing attribute notifications.
Fix Details
-GoToAsync Fix: Updated ShellNavigationManager to apply ApplyQueryAttributes when popping, ensuring QueryableAttributes values are set correctly.
-TabBar Navigation Fix: Invoked ApplyQueryAttributes within UpdateCurrentState to receive notifications for all ShellItem navigations, ensuring that QueryAttributes are updated consistently across TabBar item changes.
Issues Fixed
Fixes #13537
Output Screenshot