Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Tabs does not invoke its IQueryAttributable.ApplyQueryAttributes(query) #25663

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

SuthiYuvaraj
Copy link
Contributor

@SuthiYuvaraj SuthiYuvaraj commented Nov 4, 2024

Issue Details

While navigating between pages, ApplyQueryAttributes should trigger with data from the navigating page. In the current implementation, navigation using Push and GoToAsync works as expected, but other navigation methods do not trigger ApplyQueryAttributes notifications.

Root Cause

-GoToAsync Limitations: When navigating using PopAsync, PopModalAsync, back navigation, or between FlyoutPages, ApplyQueryAttributes is not triggered. This occurs because QueryAttributes is not correctly set for these navigation types.
-TabBar Navigation: Navigating between TabBar items changes the page by updating CurrentItemChanged. However, QueryAttributes is not updated for these item changes, leading to missing attribute notifications.

Fix Details

-GoToAsync Fix: Updated ShellNavigationManager to apply ApplyQueryAttributes when popping, ensuring QueryableAttributes values are set correctly.

-TabBar Navigation Fix: Invoked ApplyQueryAttributes within UpdateCurrentState to receive notifications for all ShellItem navigations, ensuring that QueryAttributes are updated consistently across TabBar item changes.

Issues Fixed

Fixes #13537

Output Screenshot

Before Issue Fix After Issue Fix
Before Fix video After Fix video

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Nov 4, 2024
Copy link
Contributor

Hey there @SuthiYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@SuthiYuvaraj SuthiYuvaraj changed the title Fix 13573 Fix for Tabs does not invoke its IQueryAttributable.ApplyQueryAttributes(query) Nov 4, 2024
@jsuarezruiz jsuarezruiz added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label Nov 6, 2024
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 6, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution
Projects
None yet
2 participants