Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Fix flaky UITests failing sometimes 3 - Alternative #27311

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Jan 23, 2025

Description of Change

Tests:

  • VerifyInitialEntryReturnTypeChange. Capture depends on a blinking Entry cursor. Sometimes it happens, sometimes it doesn't. Fixed test, cursor is not captured in the image.

Alternative to #27277

  • Added a mapper to just make the caret transparent by default on the UITests.
  • Added a Behavior that can add the caret back if necessary in some UITests.

@jsuarezruiz jsuarezruiz added area-testing Unit tests, device tests testing-flakiness labels Jan 23, 2025
@Copilot Copilot bot review requested due to automatic review settings January 23, 2025 16:27
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner January 23, 2025 16:27

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • src/Controls/tests/TestCases.HostApp/Platforms/MacCatalyst/IsCursorVisibleBehavior.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.HostApp/Platforms/Windows/IsCursorVisibleBehavior.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)

src/Controls/tests/TestCases.HostApp/Behaviors/IsCursorVisibleBehavior.cs:6

  • Ensure that the IsCursorVisible property is covered by tests to verify its behavior.
BindableProperty.Create(nameof(IsCursorVisible), typeof(bool), typeof(IsCursorVisibleBehavior));
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing Unit tests, device tests testing-flakiness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants