Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop ngening compat-only DLLs in subfolders #11181

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rainersigwald
Copy link
Member

These DLLs are shipped to these subfolders only for compat with applications that load from them naïvely; MSBuild.exe and VS and applications that use MSBuildLocator should only ever load them from the bin\ directory directly. So stop spending time ngening them.

Notes to January self: look at ngen logs in VS perf tests. Verify

  • no methodsJitted regressions
  • we are actually not ngening these files for x86 or amd64

These DLLs are shipped to these subfolders only for compat with
applications that load from them naïvely; MSBuild.exe and VS and
applications that use MSBuildLocator should only ever load them from the
`bin\` directory directly. So stop spending time ngening them.
Copy link
Contributor

Hello @rainersigwald, I noticed that you’re changing an .swr file or any file under src/Package/MSBuild.VSSetup.. Please make sure to validate this change by an experimental VS insertion. This is accomplished by pushing to an exp/* branch, which requires write permissions to this repo.

@rainersigwald rainersigwald self-assigned this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant