Log properties initial value

[aelij]

Fixes #2711

[aelij]

@KirillOsenkov Please review and see if this answers your needs

[cdmihai]

This change is on the hot perf path, it would be good to see perf numbers comparing the following scenarios with master msbuild:

• building a big repo (e.g. orchard core) with various logger setups (no loggers, file logger on default verbosity, file logger on debug verbosity, binary logger)
• dotnet CLI verbs on the basic project templates

[danmoseley]

As well as more work on the hot path, it also means more logging on the hot path, even if a logger is not attached or would ignore the messages (due to verbosity). There are other places in the codebase where the engine "cheats", this is the pattern:

                    if (!_loggingService.OnlyLogCriticalEvents)
                    {
                        ... log informational things
                    }

I would wrap as above, and still measure after that as this is such a critical hot path where most of the time this work is not needed.

[aelij]

@danmosemsft I added the checks you suggested.

[danmoseley]

@aelij thanks, it's not my repo, but I think they will need solid perf measurements as mentioned above. This path is perf critical not just to MSBuild but also Visual Studio project load, etc. This will have an impact as it's adding more code the question is how much.

[livarcocc]

@benvillalobos Let's do a private build of this branch and kick a VS insertion to run RPS on to double check for perf regressions.

@AndyGerlicher I think this would be a good one for our teams to review together given your heavy usage of evaluation.

[cdmihai]

@maneely Maybe it would be good to merge this PR with yours (#4461), since they're doing very related work, and the mechanism would be the same.

[rainersigwald]

@maneely Matt Neely FTE Maybe it would be good to merge this PR with yours (#4461), since they're doing very related work, and the mechanism would be the same.

Team triage: let's do that. Please tag @aelij on the PR. Since that PR is behind a feature flag, it alleviates the performance concerns we have with this approach and doing it all the time.

Thanks @aelij.

[maneely]

Will do. Thx.