Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing CPU traces for Linux for the ASP.NET scenarios #4205

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −5
Open

Allowing CPU traces for Linux for the ASP.NET scenarios #4205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions ....Infrastructure/GC.Infrastructure.Core/CommandBuilders/ASPNetBenchmarks.CommandBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,16 +67,25 @@ public static (string, string) Build(ASPNetBenchmarksConfiguration configuration

else
{
if (configuration.TraceConfigurations.Type != "gc")
if (configuration.TraceConfigurations.Type != "gc" || configuration.TraceConfigurations.Type != "cpu")
{
throw new ArgumentException($"{nameof(ASPNetBenchmarksCommandBuilder)}: Currently only GCCollectOnly traces are allowed for Linux.");
throw new ArgumentException($"{nameof(ASPNetBenchmarksCommandBuilder)}: Currently only GCCollectOnly and CPU traces are allowed for Linux.");
}

else
{
traceFileSuffix = ".nettrace";
commandStringBuilder.Append(" --application.dotnetTrace true ");
commandStringBuilder.Append(" --application.dotnetTraceProviders gc-collect ");
if (configuration.TraceConfigurations.Type == "gc")
{
traceFileSuffix = ".nettrace";
commandStringBuilder.Append(" --application.dotnetTrace true ");
commandStringBuilder.Append(" --application.dotnetTraceProviders gc-collect ");
}

else
{
commandStringBuilder.Append(" --application.collect true ");
commandStringBuilder.Append(" --application.collectStartup true ");
}
}
}

Expand Down