Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet_analyzer_diagnostic.severity Does Not Work with TreatWarningsAsErrors #55541

Closed
RehanSaeed opened this issue Aug 11, 2021 · 1 comment · Fixed by #58460
Closed

dotnet_analyzer_diagnostic.severity Does Not Work with TreatWarningsAsErrors #55541

RehanSaeed opened this issue Aug 11, 2021 · 1 comment · Fixed by #58460
Assignees
@mavasani
Labels
Area-Analyzers Bug Investigation Required
Milestone
17.1

Comments

@RehanSaeed
Copy link

Version Used:

  • VS 2019, .NET 5, #error version = Compiler version: '3.11.0-4.21403.6 (ae1fff34)'. Language version: latest (9.0).
  • .NET CLI 5.0.400 #error version = Compiler version: '3.11.0-4.21373.6 (bb3bdbbe)'. Language version: 9.0..

Steps to Reproduce:

  1. dotnet new console
  2. Add this .editorconfig file to the root of the project, it contains:
[*.{cs,csx,cake,vb,vbx}]
# Default Severity for all .NET Code Style rules below
dotnet_analyzer_diagnostic.severity = warning
  1. Add <TreatWarningsAsErrors>true</TreatWarningsAsErrors> to the .csproj file.
  2. dotnet build
  3. You get warnings instead of errors.

Expected Behavior:

You should get errors.

Actual Behavior:

You get warnings.

See also @sharwell's comments in #43051 (comment)
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Analyzers untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 11, 2021
This was referenced Aug 11, 2021
Closed
Closed
Closed
@jinujoseph jinujoseph removed the untriaged Issues and PRs which have not yet been triaged by a lead label Aug 11, 2021
@jinujoseph jinujoseph added this to the 17.0 milestone Aug 11, 2021
@edumserrano edumserrano mentioned this issue Sep 7, 2021
Closed
@mavasani
Copy link
Contributor

Verified that this is indeed a bug that would need fixing. Thanks for reporting it.

@jinujoseph jinujoseph modified the milestones: 17.0, 17.1 Dec 10, 2021
mavasani added a commit to mavasani/roslyn that referenced this issue Dec 22, 2021
@mavasani
Handle /warnaserror with Warning analyzer bulk configuration in edito…
3ae6b3c 
…rconfig

Fixes batch compiler issue in dotnet#55541. I'll create a separate PR for the fix on IDE side
@mavasani mavasani mentioned this issue Dec 22, 2021
Merged
mavasani added a commit to mavasani/roslyn that referenced this issue Dec 22, 2021
@mavasani
IDE change to handle /warnaserror with Warning analyzer bulk configur…
60def7b 
…ation in editorconfig

Underlying issue: dotnet#55541
Corresponding batch compiler fix: dotnet#58460
This change fixes the code that computes effective severity for Analyzers node. We also need to update the code that computes effective severity for EditorConfig UX, I will file a separate issue for the same.

NOTE: We have dotnet#52720 to track avoiding code duplication for computing effective severity between EditorConfig UX and other parts of the IDE
This was referenced Dec 22, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mavasani mavasani

Labels
Area-Analyzers Bug Investigation Required
Projects
None yet
Milestone
17.1
Development

Successfully merging a pull request may close this issue.

Handle /warnaserror with Warning analyzer bulk configuration in edito… mavasani/roslyn
3 participants
@RehanSaeed @mavasani @jinujoseph