Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port few IDE analyzers/fixers to shared layer to be enabled in CodeStyle NuGet package #41363
Port few IDE analyzers/fixers to shared layer to be enabled in CodeStyle NuGet package #41363
Changes from 1 commit
f18cea7
c3ecec5
2e32204
df116e9
a6579cc
2750a86
09e77dc
493b727
2046dbb
9297c51
c4ebb30
46ef3bb
53fdfe0
68c74bf
cc3910c
677d292
3e69af5
1e8b5d0
f1c5abe
26540d4
3050f34
868886a
23dc0c0
f70503d
216ab58
fb1940f
c7a3026
86304ff
7d7bfc8
f1b4a01
f0ed15e
6f9b2ce
f2f18c0
8e0fe0d
7f9d9e1
1e1b9a7
fee840f
d22e50c
870fa85
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any code accessing
OptionSet
in our shared projects is going to need such #if until we can move all our analyzer/fixers linked into Features.dll to also move toAnalyzerConfigOptions
(tracked by #41462). Even then we might have cases where we need these when a helper method in Workspace layer needs to be invoked outside the analyzer/fixer context and needs to operate onOptionSet
, while the same helper is required by some analyzer/fixer and must operate onAnalyzerConfigOptions