Allow null langword fixer at the end of an XML tag #76552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
Community
RenderMichael
force-pushed
the
null-fixer
branch
from
6647c17 to
f7dabe1
Compare
|
@CyrusNajmabadi ping regarding this small and tidy PR. I wasn't sure who else to ping, since you commented on the original issue, but this is ready for review. |
| """, | ||
|
|
||
| """ | ||
| /// <summary>Testing keyword <see langword="null"/></summary> |
There was a problem hiding this comment.
Can you add a test where the keyword is the first word in the summary and the caret is at the start of it?
There was a problem hiding this comment.
Good catch, that scenario did regress with this change. I pushed a fix and tests.
CyrusNajmabadi
approved these changes
Jan 9, 2025
|
Thanks very much for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76548
This allows users to more naturally type
nulland follow it up withCtrl+.to immediately convert to<see langword="null"/>