Skip to content

Commit

Permalink
remove fixed fixme
Browse files Browse the repository at this point in the history
  • Loading branch information
lambdageek committed Sep 30, 2024
1 parent bae8e38 commit 89d0611
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/native/managed/cdacreader/tests/NibbleMapTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -175,16 +175,13 @@ public void NibbleMapOneItemLookupOk(MockTarget.Architecture arch)
methodCode = map.FindMethodCode(mapBase, mapStart, inputPC.Value + 0x100u);
Assert.Equal<TargetPointer>(inputPC.Value, methodCode.Value);

#if true // FIXME: for expected 5f5f0200, found 5f5f0120 input address 5f5f0300

// interestingly, all addresses after the code chunk should also return the beginning of the method
// we don't track how long the method is, so we can't tell if we're past the end
for (TargetCodePointer ptr = inputPC + (uint)codeSize; ptr < MapEnd; ptr++)
{
methodCode = map.FindMethodCode(mapBase, mapStart, ptr);
Assert.Equal<TargetPointer>(inputPC.Value, methodCode);
}
#endif

}

Expand Down

0 comments on commit 89d0611

Please sign in to comment.