Improve error message when failing to locate an RVA in the R2R reader

dotnet · Sep 23, 2024 · a295c46 · a295c46
1 parent ac80472
commit a295c46
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/PEReaderExtensions.cs b/src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/PEReaderExtensions.cs
@@ -110,7 +110,10 @@ public static int GetOffset(this PEReader reader, int rva)
             int index = reader.PEHeaders.GetContainingSectionIndex(rva);
             if (index == -1)
             {
-                throw new BadImageFormatException("Failed to convert invalid RVA to offset: " + rva);
+                var sectionInfo = new StringBuilder();
+                foreach (var sh in reader.PEHeaders.SectionHeaders)
+                    sectionInfo.AppendLine($"  {sh.Name} PTRD={sh.PointerToRawData} SORD={sh.SizeOfRawData} VA={sh.VirtualAddress} VS={sh.VirtualSize}");
+                throw new BadImageFormatException($"Failed to convert invalid RVA to offset: {rva}.\nSections:\n{sectionInfo}");
             }
             SectionHeader containingSection = reader.PEHeaders.SectionHeaders[index];
             return rva - containingSection.VirtualAddress + containingSection.PointerToRawData;

diff --git a/src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ReadyToRunReader.cs b/src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ReadyToRunReader.cs
@@ -1380,7 +1380,7 @@ private void FindOwnerCompositeExecutable()
         }
 
         /// <summary>
-        /// based on <a href="https://github.com/dotnet/coreclr/blob/master/src/zap/zapimport.cpp">ZapImportSectionsTable::Save</a>
+        /// originally based on <a href="https://github.com/dotnet/coreclr/blob/master/src/zap/zapimport.cpp">ZapImportSectionsTable::Save</a>
         /// </summary>
         private void EnsureImportSections()
         {